Moved run ID management to knapsack

[cesarfda]

This pull request moves the run ID system to improve logging and tracking across the application. The changes include generating a unique run ID, setting it in the knapsack, and applying it to the logger and slogger for consistent tracking.

Resolves #1706

Run ID Implementation:

• cmd/launcher/launcher.go: Added code to generate a new run ID and set it in the knapsack, logger, and slogger.
• ee/agent/knapsack/knapsack.go: Introduced a package-level runID variable and added GetRunID method to manage the run ID within the knapsack. [1] [2]

Logger Updates:

• pkg/log/multislogger/multislogger.go: Removed the launcherRunId variable from the MultiSlogger struct and its initialization, and updated the AddHandler method to no longer include the launcher_run_id. [1] [2] [3] [4]

[RebeccaMahany]

Do we need e.g. --

k.slogger = k.slogger.With("run_id", id)
k.systemSlogger = k.systemSlogger.With("run_id", id)

? I think .With creates and then modifies a clone, so it wouldn't update k.slogger.

[cesarfda]

Yeah, I did that in launcher but missed in Knapsack. I have pushed out another commit to fix this with the assignment.

[directionless]

Do you need this method?

I'd probably do something like:

func (k *knapsack) GetRunID() string {
        if runID == "" {
            runID = ulid.New()
        }
	return runID
}

[cesarfda]

I think that wouldn't cover the scenario where we want every time runLauncher is called to have a newID, I assume we could run into a situation where the ID is persisted if runLauncher is called after an update. Let me know if that's not the case and I can change this

[directionless]

Chatted on slack -- I think this is worth testing. I'm not sure if the restart/exec would have access to the same memory

[directionless]

I think if we did need to create a specific create method, my inclination would be to make k.NewRunID() and call it on startup. I think passing in the string feels wrong.

[cesarfda]

I was able to test the scenario and after the update we do get a new ID when we generate the ID in the GET method. I refactored the code to not have a set.

[directionless]

I know this has merged, and it's fine, but I'd probably skip the variable here, and put k.GetRunID() into the two With functions

[directionless]

Hrm. This here, and the part in runLauncher feels off somehow.