add windows installer-info from registry to flares #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee/debug/checkups/install_windows.go
Outdated
| func getDefaultRegistryStringValue(path string) string { | ||
| key, err := registry.OpenKey(registry.LOCAL_MACHINE, path, registry.QUERY_VALUE) | ||
| if err != nil { | ||
| return "" |
There was a problem hiding this comment.
Do we want to use naIfError here so we can capture the additional info in the errors too, in case they're useful? Same goes for below and in getDefaultRegistryIntValue too
There was a problem hiding this comment.
oh yeah that makes sense to me! will do
There was a problem hiding this comment.
i ended up just directly returning the errors as strings to avoid dealing with the any response everywhere, I think this should achieve the same. let me know what you think!
RebeccaMahany
previously approved these changes
Nov 15, 2024
RebeccaMahany
approved these changes
Nov 15, 2024
James-Pickett
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not write out an installer-info.json file for windows - instead we write the relevant metadata to the registry during MSI installation.
This updates the package install checkup to collect that information (along with our newly added CurrentVersionNum and InstalledVersionNum keys) and write out an installer-info.json file with those values for our flares.