Set all env vars on osquery process #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
approved these changes
Nov 19, 2024
directionless
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
I think this is okay, and just to talk through it...
My normal inclination is to set a minimal ENV -- less likely to make a executated command behave unexpectedly. But, we're not running suid, and we only have the permissions we start with. So, this shouldn't negatively impact us -- if you can adjust launcher's env, you could just call osquery with that same adjusted ENV.
| // On Windows, we need to ensure the `SystemDrive` environment variable is set to _something_, | ||
| // so if it isn't already set, we set it to an empty string. | ||
| systemDriveEnvVarFound := false | ||
| for _, e := range cmd.Env { |
There was a problem hiding this comment.
Things like this make me grumpy it's an array and not a hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1960:
cmd.Environ()-- this is the default behavior forcmdwhen nothing is set incmd.EnvSystemDrivehappens to be unset, we can prevent undesirable behavior by settingSystemDrive=in the env instead -- so this PR adds a check for that as well