[KATC] Add support for doubles to indexeddb parsing #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
commented
Nov 19, 2024
| @@ -26,6 +26,7 @@ const ( | |||
| // numbers | |||
| tokenInt32 byte = 0x49 // I | |||
| tokenUint32 byte = 0x55 // U | |||
| tokenDouble byte = 0x4e // N | |||
There was a problem hiding this comment.
The source for this value, as well as the troubleshooting steps I took to fix this parsing error, are documented here: https://github.com/kolide/launcher/tree/main/ee/katc/test_data#troubleshooting-parsing-errors
zackattack01
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our indexeddb parser currently doesn't handle doubles. This PR implements parsing doubles, and updates the test database to confirm the parsing does not return an error.