Don't perform remote restart yet #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
approved these changes
Nov 21, 2024
zackattack01
approved these changes
Nov 21, 2024
|
I'd probably have left this in, and rolled it back in K2. Or popped up a warning |
|
@directionless I preferred this approach because the result on Linux is that launcher shuts down and does not restart without manual user intervention -- so it seemed safest/most prudent to make remote restart not at all possible on the launcher side, for the time being |
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially rolls back changes from #1948.
The tradeoff noted in the comment on the previous PR (#1948 (comment)) was a bigger one than I realized on Linux, so I want to think more about how to handle the restart.
In the meantime, so we can get the release out, I'm updating to keep the consumer but not use it yet.