Improvements for osqueryinstance's errgroup #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RebeccaMahany
commented
Dec 30, 2024
•
RebeccaMahany
commented
- Moves errgroup to its own package for reusability
- Adds tests for errgroup
- Adds more and better logging so that we can track whether shutdown tasks are taking a long time
- Run repeated goroutine immediately after delay, rather than waiting for another interval
- Recover panicking goroutines
RebeccaMahany
force-pushed
the
becca/errgroup
branch
from
6356118 to
cd484d1
Compare
RebeccaMahany
commented
Jan 8, 2025
| type LoggedErrgroup struct { | ||
| errgroup *errgroup.Group | ||
| cancel context.CancelFunc | ||
| doneCtx context.Context // nolint:containedctx |
There was a problem hiding this comment.
This is the same nolint exception we had previously, just moved from osqueryinstance to here. In the future I think we might be able to get rid of this entirely -- but the errgroup is very sensitive when it comes to updating anything that touches doneCtx so I want to do it in a separate PR at a later time.
James-Pickett
previously approved these changes
Jan 8, 2025
RebeccaMahany
dismissed stale reviews from zackattack01 and James-Pickett
via
f665c36
James-Pickett
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.