Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flaky tests less flaky #2036

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Jan 9, 2025

Autoupdate tests:

  • Looks like this one just needed more time to run 🤞

Rungroup tests:

  • Not sure what's up here yet, so I'm capturing the logs from rungroup and printing them on error, so we can figure out why we sometimes don't see all of the rungroup actors interrupt successfully

Osquery tests:

  • Standardize waitHealthy to wait for the osquery instance to become healthy for as long as we actually wait (1 min for the socket file to be created, 10 seconds for the socket file to become available)

@RebeccaMahany RebeccaMahany marked this pull request as ready for review January 9, 2025 16:44
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jan 9, 2025
Merged via the queue into kolide:main with commit 5811ef6 Jan 9, 2025
32 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/improve-flaky-tests branch January 9, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants