Add packaging support for specifying root CAs #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marpaia
approved these changes
Feb 22, 2018
groob
reviewed
Feb 22, 2018
tools/packaging/packaging.go
Outdated
| @@ -141,6 +141,15 @@ func CreateLinuxPackages(osqueryVersion, hostname, secret string, insecure, inse | |||
| } | |||
| } | |||
|
|
|||
| rootPEMPath := "" | |||
There was a problem hiding this comment.
nit: I would prefer to use the zero value then initializing an empty string like this in Go code.
groob
approved these changes
Feb 22, 2018
|
CI passed but I cancelled it while it waited for SSH so it would not use up resources. I manually tested this by creating packages with and without the appropriate roots in the PEM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231.