Travis-CI ands test updates #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This is starting to play wih travis-ci for the cross platform support
directionless
force-pushed
the
seph/travis-ci
branch
from
0dc0b74 to
fdfa90f
Compare
blaedj
approved these changes
Feb 20, 2019
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| var testOsqueryBinaryDirectory string | ||
|
|
||
| // TestMain overrides the default test main function. This allows us to share setup/teardown. |
There was a problem hiding this comment.
is there anything that the default test main function does for us? or is it just the os.Exit(m.Run()) by default?
There was a problem hiding this comment.
Docs imply that's all it is, and suggest it as the place to hang setup/teardown tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some initial work to get travis-ci running. This includes updates to the make the tests more reliable, and have fewer dependancies on on the initial container setup. Travis-ci is desirable for it's multiple-platforms.
This does mean that we have duplicate CI systems