Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade to nx 20 #117

Merged
merged 8 commits into from
Nov 14, 2024
Merged

Conversation

gcko
Copy link
Contributor

@gcko gcko commented Oct 16, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Configuration related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • @koliveira15/nx-sonarqube
  • docs-site (A fix to the build-docs command)

What is the current behavior?

Currently, nx-sonarqube fails when using NX 20

Closes #116

This also fixes an issue with tsquery and latest typescript. See this bug phenomnomnominal/tsquery#98

What is the new behavior?

Updated the usages of workspace to projectConfigurations

Does this PR introduce a breaking change?

  • Yes
  • No

It has been tested to work correctly with NX 20 and NX 19. I have not tested with other versions of NX

Other information

gcko added 3 commits October 16, 2024 11:28
- Bump most of the dependencies to their latest
- Don't change tsquery, that requires refactoring
- Refactor code to use `projectConfigurations` instead of `workspace`
- Fix test issues due to typescript update. @see phenomnomnominal/tsquery#98
Copy link

nx-cloud bot commented Oct 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7415607. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@gcko
Copy link
Contributor Author

gcko commented Oct 16, 2024

I went ahead and did some digging in the NX codebase (their documentation is not so good 🤷 ) and found this -> https://github.com/nrwl/nx/blame/d131b0b67709560d816b0df394c762e72a7b51d6/packages/nx/src/config/misc-interfaces.ts#L248-L253C60

{
/**
   * Deprecated. Use projectsConfigurations or nxJsonConfiguration
   * The full workspace configuration
   * @todo(vsavkin): remove after v17
   */
  workspace?: ProjectsConfigurations & NxJsonConfiguration;
}

This was Removed in NX 20, but because of this, it does mean that this PR should be feasible for NX 16 and up

@gcko
Copy link
Contributor Author

gcko commented Oct 22, 2024

hey @koliveira15 , let me know if there is anything I can do to help out with this PR - 🙏

@gcko gcko mentioned this pull request Oct 25, 2024
2 tasks
@jaredterm
Copy link

Hey @koliveira15 , please let me know if there is anything else needed for this PR.

As an aside, it might be worthwhile contacting NX and making this an official plugin 🤔 IMO static analysis is integral to development pipeline and I personally would push strongly for its inclusion to the NX family

@gcko
Copy link
Contributor Author

gcko commented Nov 4, 2024

@koliveira15 Anything I can do to help? This is becoming a blocker in our repository as it precludes us from updating nx and associated dependencies. Please let me know how I can contribute 🙏

@ErickRodrCodes
Copy link

since he is busy, I will fork it out and move it to 20. we are having the same blocker as it is critical for us to use nx import to speed up monorepo work on our side.

@ErickRodrCodes
Copy link

ErickRodrCodes commented Nov 6, 2024

It seems I am unable to create the package as I'm tied to several things at work. If there is no update in 15 days, I will retry to fork it and somehow own it... or worst thing to fork it into work and maintain it ourselves...

@gcko gcko mentioned this pull request Nov 6, 2024
2 tasks
@sceptre12
Copy link

Hey @koliveira15 Just checking to see if this PR can get merged

migrations.json Show resolved Hide resolved
gcko added 2 commits November 13, 2024 09:55
Add back migrations.json file
# Conflicts:
#	packages/nx-sonarqube/package.json
@gcko gcko requested a review from koliveira15 November 14, 2024 01:30
@koliveira15 koliveira15 linked an issue Nov 14, 2024 that may be closed by this pull request
2 tasks
@koliveira15 koliveira15 merged commit 5b1c33f into koliveira15:main Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executor fails for nx 20 Fail to find coverage paths in jest config using latest typescript 5.5.3
5 participants