Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: make sonarqube dependency less strict & include license in the build #119

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

koliveira15
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Configuration related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • @koliveira15/nx-sonarqube
  • docs-site

What is the current behavior?

  • LICENSE file is not included in the bundle
  • license is not set in the bundle's package.json
  • sonarqube-scanner npm version is static

Closes #

What is the new behavior?

  • LICENSE file is included in the bundle
  • license is set in the bundle's package.json
  • sonarqube-scanner npm version is ranged up to 4

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@koliveira15 koliveira15 self-assigned this Nov 12, 2024
@koliveira15 koliveira15 added the bug Something isn't working label Nov 12, 2024
Copy link

nx-cloud bot commented Nov 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d2d771a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@koliveira15 koliveira15 merged commit 22f9963 into main Nov 12, 2024
6 checks passed
@koliveira15 koliveira15 deleted the bugfix/missing-license-scan-dep branch November 12, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployed package is missing license information Make sonarqube-scanner version dependency less strict
1 participant