Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: account for all vite config extensions #121

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

koliveira15
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Configuration related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • @koliveira15/nx-sonarqube
  • docs-site

What is the current behavior?

The scan executor does not include .js, .mts, and .mjs as valid vite config extensions

Closes #
#112

What is the new behavior?

The scan executor does include .js, .mts, and .mjs as valid vite config extensions

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@koliveira15 koliveira15 self-assigned this Nov 14, 2024
@koliveira15 koliveira15 added the bug Something isn't working label Nov 14, 2024
Copy link

nx-cloud bot commented Nov 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3157061. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@koliveira15 koliveira15 merged commit 4903a74 into main Nov 14, 2024
6 checks passed
@koliveira15 koliveira15 deleted the bugfix/vite-cjs-config branch November 14, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to find coverage paths in vite configuration with vite 5 if CJS node API is not used anymore
1 participant