pkg/filenotify: poller.Add: fix fd leaks on err

In case of errors, the file descriptor is never closed. Fix it. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin · Aug 29, 2018 · 88bcf15 · 88bcf15
1 parent 64b7575
commit 88bcf15
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/pkg/filenotify/poller.go b/pkg/filenotify/poller.go
@@ -54,13 +54,15 @@ func (w *filePoller) Add(name string) error {
 	}
 	fi, err := os.Stat(name)
 	if err != nil {
+		f.Close()
 		return err
 	}
 
 	if w.watches == nil {
 		w.watches = make(map[string]chan struct{})
 	}
 	if _, exists := w.watches[name]; exists {
+		f.Close()
 		return fmt.Errorf("watch exists")
 	}
 	chClose := make(chan struct{})