Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

completePlace called twice on updating #631

Closed
lonvia opened this issue Jan 18, 2022 · 0 comments · Fixed by #639
Closed

completePlace called twice on updating #631

lonvia opened this issue Jan 18, 2022 · 0 comments · Fixed by #639

Comments

@lonvia
Copy link
Collaborator

lonvia commented Jan 18, 2022

It seems to happen because completePlace is called twice on updating. The second time you've another object for the same address.

It happens on these lines:

photon/src/main/java/de/komoot/photon/nominatim/NominatimConnector.java

Line 83 in ce84ef4

completePlace(doc);

photon/src/main/java/de/komoot/photon/nominatim/NominatimConnector.java

Line 148 in ce84ef4

completePlace(result.getBaseDoc());

Why is this called twice? It that on purpose?

Originally posted by @hendrikmoree in #630 (comment)
lonvia added a commit to lonvia/photon that referenced this issue Feb 17, 2022
@lonvia
remove completeDoc from single place update functions
5e0ed0b 
Docs are already completed in the rowMappers.

Fixes komoot#631.
@lonvia lonvia mentioned this issue Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove completeDoc from single-place update functions lonvia/photon
1 participant
@lonvia