Copy dependencies required for painless before resource processing #399
Conversation
simonpoole
changed the title
This removes the jar files required for the painless plugin from the repo and copies them before resources are processed. This doesn't fix the ugliness in Server.java when coping the jars, to make that at least a bit better and nearly only dependent on configuration we strip the version when copying. Further it converts indenting in pom.xml to spaces just as the rest of the code.
| <resources> | ||
| <resource> | ||
| <directory>${project.build.directory}/es/</directory> | ||
| </resource> |
There was a problem hiding this comment.
Those three lines were added and look unrelated. Or rather, if anything, they look like they should be replacing the three lines below
There was a problem hiding this comment.
No that's correct, that is the temp directory the jars are copied in to (see line 229 for example) which then in turn is used by the resources plugin as the source for creating the jars and classes directories.
|
Looks in general sensible to me but my knowledge of Java dependency management is limited. @karussell do you know of any reason why we should keep those three packages around as jars in the git repo? |
|
@lonvia maybe I should have pointed this out: the jar files in question are a runtime dependency and are used for an ES plugin that provides some scripting support. maven (even though I hate it) handles compile time dependencies just fine, but this was a tiny bit tricky. So it isn't -really- java related at all, they are simply files that are copied out of the jar in to the ES directory. |
This removes the jar files required for the painless plugin from the
repo and copies them before resources are processed.
This doesn't fix the ugliness in Server.java when coping the jars,
to make that at least a bit better and nearly only dependent on
configuration we strip the version when copying.
Further it converts indenting in pom.xml to spaces just as the rest of
the code.