Add command line option to fetch updates and exit afterwards #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nakaner
force-pushed
the
return-after-update
branch
from
54081f3
to
2f45740
Compare
lonvia
reviewed
May 11, 2020
| @@ -20,6 +20,9 @@ | |||
| @Parameter(names = "-nominatim-import", description = "import nominatim database into photon (this will delete previous index)") | |||
| private boolean nominatimImport = false; | |||
|
|
|||
| @Parameter(names = "-nominatim-update", description = "fetch updates from nominatim database into photon and exit (this updates the index only without offering an API") | |||
There was a problem hiding this comment.
Missing closing bracket in the description.
| esClient.admin().cluster().prepareHealth().setWaitForGreenStatus().execute().actionGet(); | ||
| final NominatimUpdater nominatimUpdater = setupNominatimUpdater(args, esClient); | ||
| nominatimUpdater.update(); | ||
| } else { |
There was a problem hiding this comment.
Please keep with the style of the other ifs and do the return; instead of the else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing Photon upgrades on a (master) host not serving requests but getting its database rsynced to remote hosts, it is pretty annoying that it is only visible in the logfile when an update is completed. Therefore, I propose to add a new option
-nominatim-updatewhich makes Photon start, apply updates from Nominatim and then exit.