Always use Index API for updates #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating one-size-fits all content for the test ES DB, have each test create the data it needs.
Removes the constructor with far too many parameters and makes it easier to construct PhotonDocs for testing.
Very simple tests to confirm a bug with the update code.
The Update API merges the given document with an existing one. We need to completely replace the document, which is done via the Index API. Fixes komoot#525.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Update API merges the given document with an existing one. We need to completely replace the document, which is done via the Index API.
Also adds tests for the case where a name is removed which confirms the issue. To make it easier to write these tests I've changed PhotonDoc to a builder pattern to get rid of the rather uncomfortably long constructor. See separate commits for details.
Fixes #525.