Clean up filter tests and add tests for basic searches #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factors out common code and reformats the tests to make them more readable.
All query tests concerning the PhotonQueryBuilder are now collected in files called Query*Test.
These tests check that all fields can be searched for as expected. They do not test correctness of order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings a bit more order into the tests for the PhotonQueryBuilder. Unit tests remain in
PhotonQueryBuilderTest.java. All tests that check that the queries actually produce the desired results are now in files namedQuery*Test.The new tests are mainly there to ensure that places can be found at all with the expected query. They don't test for correct result ordering.