Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiplatform implementation #7

Merged
merged 5 commits into from
Apr 9, 2019
Merged

Multiplatform implementation #7

merged 5 commits into from
Apr 9, 2019

Conversation

RiccardoM
Copy link
Contributor

Changes

  • Changed the whole code architecture in order to allow multiplatform usage of the library.

Additions

  • Added the ripemd160 module
  • Added the keccak module
  • Added the extensions module

Removals

  • I had to remove Gradle Witness as I don't know how to make it work inside multiplatform projects

@RiccardoM RiccardoM changed the title WIP: Multiplatform implementation Multiplatform implementation Apr 9, 2019
@RiccardoM
Copy link
Contributor Author

All the tests should pass correctly and the PR should be ready to be merged

ligi
ligi requested changes Apr 9, 2019
View reviewed changes
README.md Show resolved Hide resolved
ligi
ligi approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see failing tests:

khash.sha256.Sha256Tests > testHashRawBytes FAILED
    java.lang.AssertionError at Sha256Tests.kt:36

khash.sha256.Sha256Tests > testDigest FAILED
    java.lang.AssertionError at Sha256Tests.kt:26

@RiccardoM
Copy link
Contributor Author

I see failing tests:

khash.sha256.Sha256Tests > testHashRawBytes FAILED
    java.lang.AssertionError at Sha256Tests.kt:36

khash.sha256.Sha256Tests > testDigest FAILED
    java.lang.AssertionError at Sha256Tests.kt:26

Should be fixed now. I think this was due to a wrong mockkObject call that made the Sha256 object return a different result in subsequent tests. With the last commit this should be fixed.

@ligi
Remove test task - not there anymore in a multi-module build
0e6d8e7 
but build task already runs the test task - so also not needed
@ligi ligi merged commit 0e6d8e7 into komputing:master Apr 9, 2019
@ligi
Copy link
Member

ligi commented Apr 9, 2019

dam - just saw now after the merge that the module structure is wrong - sha256 is in sha3 - this is wrong - can you fix @RiccardoM

@RiccardoM
Copy link
Contributor Author

@ligi Implemented the fix inside GH-8

@ligi ligi mentioned this pull request May 6, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligi ligi ligi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RiccardoM @ligi