Allow python to use default locale instead of requiring GB #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologize for the delay, I missed this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
myLocale=locale.setlocale(category=locale.LC_ALL, locale="en_GB.UTF-8")
This fails on my (windows7/10) machines due to missing the locale "en_GB.UTF-8". This prevents this script (q_routine.py) from running, and ultimately blocks all the chart/graph functionality of sublime-q (i.e. pressing f4 does nothing).
I think the correct workaround is to just use locale="" as this should allow Python to use a default locale on the machine. This works on my US Windows/MacOS machines, but please do try on some on your end to confirm!
As an alternative, we could also wrap setlocale in a try/except block. I do not think it should be necessary for users to have en_GB locale installed. Let me know what you think.
Thanks.