Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove V1 endpoints, use V2 instead of. And improve some logics #101

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Remove V1 endpoints, use V2 instead of. And improve some logics #101

merged 3 commits into from
Jun 5, 2024

Conversation

canack
Copy link
Member

@canack canack commented May 27, 2024

@canack canack added the enhancement New feature or request label May 27, 2024
@canack canack self-assigned this May 27, 2024
@canack canack requested review from yeyisan, uerkut and mgulter May 29, 2024 11:27
yeyisan
yeyisan reviewed Jun 3, 2024
View reviewed changes
client/projects.go Outdated Show resolved Hide resolved
yeyisan
yeyisan reviewed Jun 3, 2024
View reviewed changes
client/scanners.go Outdated Show resolved Hide resolved
yeyisan
yeyisan reviewed Jun 3, 2024
View reviewed changes
cmd/listScanners.go Outdated Show resolved Hide resolved
nerginturgut
nerginturgut approved these changes Jun 3, 2024
View reviewed changes
Copy link

@nerginturgut nerginturgut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

yeyisan
yeyisan requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@yeyisan yeyisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs some minor changes, which I also mentioned as a comment.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@canack canack requested a review from yeyisan June 4, 2024 11:10
@yeyisan yeyisan merged commit 8cb8226 into master Jun 5, 2024
1 check passed
@yeyisan yeyisan deleted the hotfix/v1.0.32-migrate-apiv1-to-apiv2 branch June 12, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerginturgut nerginturgut nerginturgut approved these changes

@gormelof gormelof Awaiting requested review from gormelof

@uerkut uerkut Awaiting requested review from uerkut

@mgulter mgulter Awaiting requested review from mgulter

@yeyisan yeyisan Awaiting requested review from yeyisan

Assignees

@canack canack

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canack @yeyisan @nerginturgut