Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add docker-build-multi-platform-oci-ta pipeline test #1464

Merged

Conversation

tisutisu
Copy link
Contributor

@tisutisu tisutisu commented Nov 25, 2024

Description

This PR adds the docker-build-multi-platform-oci-ta pipeline test back, fixes the rule to run build tests

Issue ticket number and link

https://issues.redhat.com/browse/KFLUXBUGS-1646

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested it here

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link
Contributor

@tnevrlka tnevrlka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@psturc
Copy link
Member

psturc commented Nov 27, 2024

@tisutisu the rule for build-definitions test selection probably needs to be updated. It did not run any tests in this PR

exec: ginkgo "--seed=1732550055" "--timeout=1h30m0s" "--grace-period=30s" "--output-interceptor-mode=none" "--focus-file=tests/build/build_templates_scenarios.go" "--no-color" "--junit-report=e2e-report.xml" "--procs=20" "--nodes=20" "--p" "--output-dir=/tmp/tmp.k7llbDiL6k" "./cmd" "--"
...
Ran 0 of 376 Specs in 0.402 seconds

full log

@tisutisu
Copy link
Contributor Author

@tisutisu the rule for build-definitions test selection probably needs to be updated. It did not run any tests in this PR

exec: ginkgo "--seed=1732550055" "--timeout=1h30m0s" "--grace-period=30s" "--output-interceptor-mode=none" "--focus-file=tests/build/build_templates_scenarios.go" "--no-color" "--junit-report=e2e-report.xml" "--procs=20" "--nodes=20" "--p" "--output-dir=/tmp/tmp.k7llbDiL6k" "./cmd" "--"
...
Ran 0 of 376 Specs in 0.402 seconds

full log

@psturc good catch, fixed in the latest commit.

@tisutisu
Copy link
Contributor Author

/retest

Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psturc, tnevrlka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit be7978b into konflux-ci:main Nov 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants