fix(HACBS-1826): pass scenario parameters to the pipeline #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that the parameters provided via the `params` field of IntegrationTestScenarioSpec are passed to the derived PipelineRun. Signed-off-by: Zoran Regvart <zregvart@redhat.com>
zregvart
force-pushed
the
pr/pass-params
branch
from
f90424e
to
b382b98
Compare
simonbaird
approved these changes
Feb 20, 2023
|
Why |
simonbaird
approved these changes
Feb 20, 2023
|
Thanks for fixing this one! |
I wasn't sure if that was a bug. Could change it, not sure if release notes are generated from commit messages... |
jsztuka
changed the title
sonam1412
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the parameters provided via the
paramsfield of IntegrationTestScenarioSpec are passed to the derived PipelineRun.