-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(HACBS-1826): pass scenario parameters to the pipeline #114
Conversation
This makes sure that the parameters provided via the `params` field of IntegrationTestScenarioSpec are passed to the derived PipelineRun. Signed-off-by: Zoran Regvart <zregvart@redhat.com>
f90424e
to
b382b98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for fixing this one! |
I wasn't sure if that was a bug. Could change it, not sure if release notes are generated from commit messages... |
This makes sure that the parameters provided via the
params
field of IntegrationTestScenarioSpec are passed to the derived PipelineRun.