-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent out-of-order deployments #115
Prevent out-of-order deployments #115
Conversation
MartinBasti
commented
Feb 21, 2023
Helper functions to get succesfull runs of build pipeline runs. I had to move `HasPipelineRunSucceeded` to `helpers` because it was impossible to use it due ircular dependencies. Signed-off-by: Martin Basti <mbasti@redhat.com>
Codecov ReportBase: 70.98% // Head: 70.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 70.98% 70.13% -0.86%
==========================================
Files 25 25
Lines 2223 2297 +74
==========================================
+ Hits 1578 1611 +33
- Misses 494 537 +43
+ Partials 151 149 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Fixing race condition where older pipeline could replace newer deployment with image from older pipeline, if olded pipeline was running longer than latest one. Signed-off-by: Martin Basti <mbasti@redhat.com>
28d1378
to
fd410fc
Compare
Make sure that correct log entry has been emitted. Signed-off-by: Martin Basti <mbasti@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!