Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump redhat-appstudio/application-api version #119

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

MartinBasti
Copy link
Collaborator

We are having issues with deprecated dependency.
Newer version of application api doesn't use deprecated dependency of sigs.k8s.io/controller-runtime/pkg/envtest/printer

@MartinBasti
Copy link
Collaborator Author

This should unblock #113 for real now :D

We are having issues with deprecated dependency.
Newer version of application api doesn't use deprecated dependency of
sigs.k8s.io/controller-runtime/pkg/envtest/printer

Signed-off-by: Martin Basti <mbasti@redhat.com>
Copy link
Contributor

@jsztuka jsztuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, crossed fingers

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 70.78% // Head: 71.35% // Increases project coverage by +0.56% 🎉

Coverage data is based on head (1dfa00c) compared to base (b61f2ec).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   70.78%   71.35%   +0.56%     
==========================================
  Files          25       25              
  Lines        2297     2297              
==========================================
+ Hits         1626     1639      +13     
+ Misses        514      504      -10     
+ Partials      157      154       -3     
Impacted Files Coverage Δ
controllers/snapshot/snapshot_adapter.go 52.45% <0.00%> (-4.27%) ⬇️
controllers/pipeline/pipeline_controller.go 65.78% <0.00%> (+5.26%) ⬆️
controllers/scenario/scenario_adapter.go 71.11% <0.00%> (+5.55%) ⬆️
controllers/scenario/scenario_controller.go 97.82% <0.00%> (+19.56%) ⬆️
controllers/scenario/predicates.go 57.14% <0.00%> (+42.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@dheerajodha dheerajodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@MartinBasti MartinBasti merged commit 33251b4 into konflux-ci:main Feb 23, 2023
@MartinBasti MartinBasti deleted the bump-application-api branch February 23, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants