Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore .DS_Store in .gitignore #629

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

hongweiliu17
Copy link
Contributor

Signed-off-by: Hongwei Liu hongliu@redhat.com

Maintainers will complete the following section

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.52%. Comparing base (3a3e148) to head (4ec2b4c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   72.35%   72.52%   +0.17%     
==========================================
  Files          46       46              
  Lines        4572     4572              
==========================================
+ Hits         3308     3316       +8     
+ Misses        916      908       -8     
  Partials      348      348              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsztuka
Copy link
Contributor

jsztuka commented Mar 25, 2024

LGTM, will add approval once the gobin change is created separatedly.

Signed-off-by: Hongwei Liu <hongliu@redhat.com>
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants