-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(HACBS-1535): Improve test coverage #97
fix(HACBS-1535): Improve test coverage #97
Conversation
Test a case when a test pipelinerun is without component and aplication names is taken from pipeline run itself Signed-off-by: Martin Basti <mbasti@redhat.com>
Codecov ReportBase: 68.23% // Head: 70.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 68.23% 70.71% +2.48%
==========================================
Files 24 25 +1
Lines 2147 2223 +76
==========================================
+ Hits 1465 1572 +107
+ Misses 539 499 -40
- Partials 143 152 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I've no idea how codecov is reporting coverage, in my local coverage it's higher. And files I haven't touched are suddenly changing coverage |
When applicaton is nil, it should fail gracefully instead of panic. Signed-off-by: Martin Basti <mbasti@redhat.com>
Body of EnsureSnapshotPassedAllTests depends mainly on test pipeline. Without test pipelinerun it just skips majority of code. Adding label test to pipeline run, to increase coverage. Signed-off-by: Martin Basti <mbasti@redhat.com>
a1a38f1
to
1288c6c
Compare
Add test coverage for updateExistingSnapshotEnvironmentBindingWithSnapshot Signed-off-by: Martin Basti <mbasti@redhat.com>
1288c6c
to
1f031ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
See the commits