fix(HACBS-1535): Improve test coverage #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test a case when a test pipelinerun is without component and aplication names is taken from pipeline run itself Signed-off-by: Martin Basti <mbasti@redhat.com>
MartinBasti
changed the title
Codecov ReportBase: 68.23% // Head: 70.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 68.23% 70.71% +2.48%
==========================================
Files 24 25 +1
Lines 2147 2223 +76
==========================================
+ Hits 1465 1572 +107
+ Misses 539 499 -40
- Partials 143 152 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I've no idea how codecov is reporting coverage, in my local coverage it's higher. And files I haven't touched are suddenly changing coverage |
When applicaton is nil, it should fail gracefully instead of panic. Signed-off-by: Martin Basti <mbasti@redhat.com>
Body of EnsureSnapshotPassedAllTests depends mainly on test pipeline. Without test pipelinerun it just skips majority of code. Adding label test to pipeline run, to increase coverage. Signed-off-by: Martin Basti <mbasti@redhat.com>
MartinBasti
force-pushed
the
update-test-coverage-2
branch
2 times, most recently
from
a1a38f1
to
1288c6c
Compare
Add test coverage for updateExistingSnapshotEnvironmentBindingWithSnapshot Signed-off-by: Martin Basti <mbasti@redhat.com>
MartinBasti
force-pushed
the
update-test-coverage-2
branch
from
1288c6c
to
1f031ba
Compare
MartinBasti
requested review from
dirgim,
hongweiliu17,
jinqi7,
Josh-Everett and
jsztuka
Josh-Everett
approved these changes
Feb 17, 2023
hongweiliu17
approved these changes
Feb 20, 2023
jinqi7
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commits