-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RELEASE-1310): add update-cr-status to push-disk-images #717
feat(RELEASE-1310): add update-cr-status to push-disk-images #717
Conversation
Hi @maorfr. Thanks for your PR. I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@maorfr: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-gj242 |
fc65c0a
to
855066c
Compare
855066c
to
7ec35ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with adding the task to the pipeline although it will do nothing for now. I don't agree with putting the snapshot in release artifacts. What we really need is a story like the ones on this epic https://issues.redhat.com/browse/RELEASE-878 for the push-disk-images task
575f7fb
to
d5b0a36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing but otherwise lgtm
5ab484c
to
4d4fd83
Compare
/retest |
1 similar comment
/retest |
5668f17
to
cebc888
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, except for the failing test - as Johnny also pointed out in Slack:
the -production test pipeline failed now because no staged.files exist in the dummy snapshot created for it. All of the tests will need it now (or make the jq not fail if the fields are missing)
cebc888
to
fa6e6e4
Compare
Signed-off-by: Maor Friedman <mafriedm@redhat.com>
fa6e6e4
to
9d59dfe
Compare
No e2e test for this pipeline so merging without it |
this commit adds the
update-cr-status
task to thepush-disk-images
pipeline.related to: https://issues.redhat.com/browse/RELEASE-1310