refactor(RELEASE-1191): use simple-signing-pipeline for irs #723
+27
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this works then we know we can use git resolvers in internal request pipelineruns |
mmalina
reviewed
Dec 3, 2024
mmalina
previously approved these changes
Dec 3, 2024
|
e2e error: |
johnbieren
force-pushed
the
release1191_2
branch
from
edcad3b
to
d114e3c
Compare
|
New changes are detected. LGTM label has been removed. |
This commit modifies the signing tasks that create InternalRequests. It changes them to use `simple-signing-pipeline` instead of `hacbs-signing-pipeline`. The former is our copy of the latter. This gives us more control over the pipeline. Signed-off-by: Johnny Bieren <jbieren@redhat.com>
johnbieren
force-pushed
the
release1191_2
branch
from
d114e3c
to
105abc2
Compare
|
@johnbieren: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-r25vp |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the signing tasks that create InternalRequests. It changes them to use
simple-signing-pipelineinstead ofhacbs-signing-pipeline. The former is our copy of the latter. This gives us more control over the pipeline.