Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RELEASE-1342): support internal-pipelinerun in sign-index-image #735

Merged
merged 1 commit into from
Dec 10, 2024
Merged

feat(RELEASE-1342): support internal-pipelinerun in sign-index-image #735

merged 1 commit into from
Dec 10, 2024

Conversation

scoheb
Copy link
Collaborator

@scoheb scoheb commented Dec 9, 2024 •
edited
Loading

Describe your changes

  • Updated the sign-index-image task to support the
    internal-pipelinerun requestType
  • New mandatory parameter releasePlanAdmissionPath
    • It is needed in order to obtain the serviceAccount so
      it can be used in the PipelineRun definition for the
      internal-pipelinerun

Relevant Jira

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I have bumped the task/pipeline version string and updated changelog in the relevant README
  • I read CONTRIBUTING.MD and commit formatting

@scoheb scoheb requested a review from a team as a code owner December 9, 2024 15:38
@scoheb scoheb force-pushed the index-image-sign-plr branch 3 times, most recently from c8eeffe to c62b065 Compare December 9, 2024 15:44
@mmalina
Copy link
Contributor

mmalina commented Dec 9, 2024 •
edited
Loading

Can you add more details about why RPA is needed in the PR description and commit message? Why this change? Is it also provided in the rh-sign-image task? How come IR doesn't need it, but internal-pipelinerun does?

It seems it's just because we need to know which service account to use?

@scoheb scoheb force-pushed the index-image-sign-plr branch from c62b065 to a825ccb Compare December 9, 2024 16:21
@scoheb
Copy link
Collaborator Author

scoheb commented Dec 9, 2024

Can you add more details about why RPA is needed in the PR description and commit message? Why this change? Is it also provided in the rh-sign-image task? How come IR doesn't need it, but internal-pipelinerun does?

updated the PR description.

It seems it's just because we need to know which service account to use?

yes

@scoheb scoheb requested review from johnbieren and mmalina December 9, 2024 16:22
@scoheb scoheb force-pushed the index-image-sign-plr branch 3 times, most recently from 586be9e to 05b9a1d Compare December 9, 2024 16:47
@scoheb scoheb force-pushed the index-image-sign-plr branch 2 times, most recently from d94a214 to b1fca83 Compare December 9, 2024 17:04
@scoheb scoheb changed the title fix(RELEASE-1342): fix sign-index-image feat(RELEASE-1342): support internal-pipelinerun in sign-index-image Dec 9, 2024
@scoheb scoheb requested review from mmalina and johnbieren December 9, 2024 17:06
johnbieren
johnbieren previously approved these changes Dec 9, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Dec 9, 2024
@scoheb
Copy link
Collaborator Author

scoheb commented Dec 9, 2024

Unable to connect to the server: dial tcp: lookup api.kx-9a25828a67.uhxk.p3.openshiftapps.com on 172.30.0.10:53: no such host

@scoheb
Copy link
Collaborator Author

scoheb commented Dec 9, 2024

/retest

@scoheb scoheb force-pushed the index-image-sign-plr branch from b1fca83 to bb2d37e Compare December 9, 2024 20:00
@openshift-ci openshift-ci bot removed the lgtm label Dec 9, 2024
@openshift-ci openshift-ci bot added the lgtm label Dec 9, 2024
@scoheb
Copy link
Collaborator Author

scoheb commented Dec 9, 2024

pods "managed-dsmrk-update-cr-status-pod" not found

@scoheb
Copy link
Collaborator Author

scoheb commented Dec 9, 2024

/retest

@scoheb
feat(RELEASE-1342): support internal-pipelinerun
ac7051e 
- Updated the sign-index-image task to support the
  `internal-pipelinerun` requestType
- New mandatory parameter `releasePlanAdmissionPath`
  - It is needed in order to obtain the serviceAccount so
    it can be used in the PipelineRun definition for the
    internal-pipelinerun

Signed-off-by: Scott Hebert <scoheb@gmail.com>
@scoheb scoheb force-pushed the index-image-sign-plr branch from bb2d37e to ac7051e Compare December 10, 2024 13:30
@openshift-ci openshift-ci bot removed the lgtm label Dec 10, 2024
@scoheb scoheb enabled auto-merge (squash) December 10, 2024 13:30
@openshift-ci openshift-ci bot added the lgtm label Dec 10, 2024
@scoheb scoheb merged commit 5071da4 into konflux-ci:development Dec 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbieren johnbieren johnbieren approved these changes

@mmalina mmalina mmalina approved these changes

Assignees

@mmalina mmalina

@johnbieren johnbieren

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scoheb @mmalina @johnbieren