fix(KONFLUX-4292): upload a fixed gpg key id to pyxis #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbieren
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Would you like me to merge this @ralphbean or hold off for now?
mmalina
approved these changes
Sep 12, 2024
|
Yes, please. Merge when you're ready. I'll rebase now. |
To fix KONFLUX-4175, we need to upload a gpg key id to pyxis. The right way to do this is for the SBOM itself to contain the gpg key id. Our task here would simply copy it to pyxis. However, to do that fully, we'll need to get a change into both syft and cachi2, which may take some time. As a stopgap, this change inspects the "publisher" field of the sbom. If it is set to Red Hat, we'll publish the Red Hat release2 key id to pyxis. You might ask, what if the rpms are not actually signed by Red Hat keys? We have a separate layer of protection against that in KONFLUX-3149, but the data about which rpms are signed by which keys will not be exposed by that work in the way that the release process can use here. * https://issues.redhat.com/browse/KONFLUX-4292 * https://issues.redhat.com/browse/KONFLUX-4175 This change should be reverted as a part of completing KONFLUX-4175. Signed-off-by: Ralph Bean <rbean@redhat.com>
ralphbean
force-pushed
the
rpm-gpg-workaround
branch
from
1ba0161
to
575c509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix KONFLUX-4175, we need to upload a gpg key id to pyxis.
The right way to do this is for the SBOM itself to contain the gpg key id. Our task here would simply copy it to pyxis. However, to do that fully, we'll need to get a change into both syft and cachi2, which may take some time.
As a stopgap, this change inspects the "publisher" field of the sbom. If it is set to Red Hat, we'll publish the Red Hat release2 key id to pyxis.
You might ask, what if the rpms are not actually signed by Red Hat keys? We have a separate layer of protection against that in KONFLUX-3149, but the data about which rpms are signed by which keys will not be exposed by that work in the way that the release process can use here.
This change should be reverted as a part of completing KONFLUX-4175.