feat(RELEASE-1144): push content sets to Pyxis #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalina
force-pushed
the
push-content-sets
branch
3 times, most recently
from
53d3493
to
a4c2712
Compare
johnbieren
reviewed
Sep 16, 2024
Yeah, it's weird. It did show the diff properly for the main py file, but not for the test file. Maybe too many changes? |
mmalina
force-pushed
the
push-content-sets
branch
from
a4c2712
to
2f506e2
Compare
johnbieren
approved these changes
Sep 16, 2024
The `upload_rpm_manifest` script was renamed to `upload_rpm_data`. On top of the rpm manifest, it will now also update the ContainerImage.content_sets field in Pyxis. The content sets is a list of unique strings taken from the repository_id qualifier of purl entries. Signed-off-by: Martin Malina <mmalina@redhat.com>
mmalina
force-pushed
the
push-content-sets
branch
from
2f506e2
to
62b09be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
upload_rpm_manifestscript was renamed toupload_rpm_data.On top of the rpm manifest, it will now also update the ContainerImage.content_sets field in Pyxis.
The content sets is a list of unique strings
taken from the repository_id qualifier of purl
entries.
I tested the script by running it against several images in stage Pyxis. I hit different scenarios (no content sets in pyxis, then saved and skipped, and also no content sets in the sbom) and it all seemed to work.