Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to use image cache to make build faster #168

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

skabashnyuk
Copy link
Collaborator

What does this PR do?

Attempt to use image cache to make build faster

Screenshot/screencast of this PR

n/a

What issues does this PR fix or reference?

Our docker image has a separate layer which is responsible to cache dependencies. To reuse this we nee to enable this capability and save layer for the next execution.
Context: https://github.com/docker/build-push-action/blob/master/docs/advanced/cache.md

How to test this PR?

n/a

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #168 (15c8191) into main (81763d2) will decrease coverage by 0.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   61.91%   61.43%   -0.49%     
==========================================
  Files          51       51              
  Lines        3319     3319              
==========================================
- Hits         2055     2039      -16     
- Misses       1074     1085      +11     
- Partials      190      195       +5     
Impacted Files Coverage Δ
controllers/spiaccesstokenbinding_controller.go 70.87% <0.00%> (-3.24%) ⬇️
pkg/spi-shared/tokenstorage/vault.go 51.40% <0.00%> (-2.81%) ⬇️
controllers/spiaccesstoken_controller.go 70.93% <0.00%> (-1.48%) ⬇️
integration_tests/serviceprovider_mock.go 81.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81763d2...15c8191. Read the comment docs.

@skabashnyuk skabashnyuk merged commit 3b5cc2b into konflux-ci:main Jun 28, 2022
@skabashnyuk skabashnyuk deleted the dockercache branch June 28, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants