fix(tianmu): fix bug: Convert DATETIME to TIME type error. (stoneatom…

…#995)

[summary]
1 treat zero data legal;

mysql-test/suite/tianmu/r/issue995.result

@@ -0,0 +1,15 @@
+USE test;
+CREATE TABLE t1 (a CHAR(1), b INT, c DATETIME, d DOUBLE);
+INSERT INTO t1 VALUES ('', NULL, '0-0-0', NULL),
+('a', 12, '1212-12-12', 1.19691E+100),
+('b', 13, '1313-3-13 13:13:13', 2.1961E+18),
+('c', 14, '1414-4-14', 0.16191),
+('d', 15, '2015-5-15 15:15:15', 1.971917);
+SELECT CONVERT(c, TIME) FROM t1;
+CONVERT(c, TIME)
+00:00:00
+00:00:00
+13:13:13
+00:00:00
+15:15:15
+DROP TABLE t1;

mysql-test/suite/tianmu/t/issue995-master.opt

@@ -0,0 +1 @@
+--sql_mode=NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION

mysql-test/suite/tianmu/t/issue995.test

@@ -0,0 +1,14 @@
+--source include/have_tianmu.inc
+
+USE test;
+
+CREATE TABLE t1 (a CHAR(1), b INT, c DATETIME, d DOUBLE);
+
+INSERT INTO t1 VALUES ('', NULL, '0-0-0', NULL),
+('a', 12, '1212-12-12', 1.19691E+100),
+('b', 13, '1313-3-13 13:13:13', 2.1961E+18),
+('c', 14, '1414-4-14', 0.16191),
+('d', 15, '2015-5-15 15:15:15', 1.971917);
+
+SELECT CONVERT(c, TIME) FROM t1;
+DROP TABLE t1;

storage/tianmu/core/item_tianmu_field.cpp

@@ -188,10 +188,11 @@ bool Item_tianmufield::get_date(MYSQL_TIME *ltime, uint fuzzydate) {
 }
 
 bool Item_tianmufield::get_time(MYSQL_TIME *ltime) {
-  if ((null_value = buf->null) ||
-      ((tianmu_type.attrtype == common::ColumnType::DATETIME || tianmu_type.attrtype == common::ColumnType::DATE) &&
-       buf->x == 0))  // zero date is illegal
-    return 1;         // like in Item_field::get_time - return 1 on null value.
+  // Consider zero date is legal , not consider the sql_mode NO_ZERO_DATE/NO_ZERO_IN_DATE.
+  // Because NO_ZERO_DATE/NO_ZERO_IN_DATE is deprecated; expect it to be removed in a future
+  // release of MySQL as a separate mode name and its effect included in the effects of strict SQL mode.
+  if ((null_value = buf->null))
+    return 1;  // like in Item_field::get_time - return 1 on null value.
   FeedValue();
   return ivalue->get_time(ltime);
 }