Ensure unique x-coordinates with sampling (Fixes #20)

[sidsbrmnn]

This pull request fixes an issue where duplicate x-coordinates could be generated. The fix involves using random sampling to ensure that all x-coordinates in the list are unique.

Changes Made

• pyshamir.py - use random.sample() to generate a list of unique numbers than manually loop to generate a random secret.
• test_pyshamir.py - manually test that the parts are different

[sidsbrmnn]

Oops! Looks like we can't use random.sample(). Hmm, maybe just brute force the uniqueness.

[konidev20]

Can we make x_coordinates a set?

Also, thinking if generating random numbers per array index is a good idea in terms of security?

Need to check the best way to generate a random array correctly.

[Loadingname91]

Can we make x_coordinates a set?

Also, thinking if generating random numbers per array index is a good idea in terms of security?

Need to check the best way to generate a random array correctly.

How about using this

import secrets x_coordinates = list(range(256)) secrets.SystemRandom().shuffle(x_coordinates) x_coordinates = x_coordinates[:-1]

[konidev20]

LGTM. @Loadingname91 , @AbhishekSrikanth please check and let me know.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication