Upgrade GO 1.22.0

[juldrixx]

Q	A
Bug fix?	no
New feature?	no
API breaks?	no
Deprecations?	no
Related tickets	-
License	Apache 2.0

What's in this PR?

Upgrade of GOLANG to 1.22.0.

Why?

To be up to date.

Checklist

• Implementation tested
• Error handling code meets the guideline
• Logging code meets the guideline
• User guide and development docs updated (if needed)
• Append changelog with changes

[juldrixx]

Not sure what is the issue, any idea @mh013370?

[mh013370]

Not sure what is the issue, any idea @mh013370?

Does make generate work locally? It's possible either the operator-sdk or something in the nifikop code isn't go 1.22 compatible?

[juldrixx]

Not sure what is the issue, any idea @mh013370?

Does make generate work locally? It's possible either the operator-sdk or something in the nifikop code isn't go 1.22 compatible?

With an existing bin directory from previous go version yes, but without it no.

[mh013370]

Not sure what is the issue, any idea @mh013370?

Does make generate work locally? It's possible either the operator-sdk or something in the nifikop code isn't go 1.22 compatible?

With an existing bin directory from previous go version yes, but without it no.

Looks like it's the version of controller-gen kubernetes-sigs/controller-tools#880

Updating to latest apparently fixes it. It's updated already in #366. Propose we merge that one first

[juldrixx]

The upgrade to v0.13.0 doesn't fix the issue.

[mh013370]

The upgrade to v0.13.0 doesn't fix the issue.

There was an issue that was just raised against golang about this. Linked from controller-tools#880

[juldrixx]

It seems that upgrading controller-tools to v0.14.0 fix the issue.

[mh013370]

It seems that upgrading controller-tools to v0.14.0 fix the issue.

I'm taking a look through the kubebuilder docs to see if the version matters that much. If i can't find anything, perhaps we just roll with 0.14.0

[juldrixx]

It seems that upgrading controller-tools to v0.14.0 fix the issue.

I'm taking a look through the kubebuilder docs to see if the version matters that much. If i can't find anything, perhaps we just roll with 0.14.0

The update seems to cause some 1 CRD update but make generate manifests still works.

https://github.com/konpyutaika/nifikop/pull/386/files#diff-554f0df8adba68afa95657f37bc4355a0120e04861526d7fbb0cf00ae0ecf84bR1935

[mh013370]

I don't see anything concerning in the kubebuilder docs. I say we just make sure nifikop continues to behave in real scenarios and revisit if needed.

[mh013370]

It seems that upgrading controller-tools to v0.14.0 fix the issue.

Good find!