Simplify configuration #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Outdated and weird, reimplement some other way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses parts of #121
K8s::Configis replaced with an unvalidated and unstructured hash. Validating kubeconfig -files is not in the scope ofk8s-client. In the future, this can lead to dropping the dry-dependencies, making the client easier to use in projects that have dry-dependecies of their own, which seem to generate a lot of dependency issues.RecursiveOpenStruct, the config uses a simple selfmade hash-extension that pretty much works the same. Later the dependency can be dropped and api-responses returned as these dot-notated hashes./etc/kubernetes/admin.confand/etc/kubernetes/kubelet.confwhen autoconfiguring, making k8s-client work with zero config when running on kube nodes.Pharos::Kube::Configwhich handles pretty much the same task with considerably less code than k8s before this pr.Specs pass but still needs some cleanup and yardoc fixes.