Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing values in Preview for Metadata component #126

Closed
Simply007 opened this issue Feb 18, 2019 · 2 comments · Fixed by #127
Closed

Handle missing values in Preview for Metadata component #126

Simply007 opened this issue Feb 18, 2019 · 2 comments · Fixed by #127
Labels

Comments

@Simply007
Copy link
Contributor

Motivation

As was described in #115, there is insufficient check for missing values for Metadata component values.

Great jop @Karl-EdwardFPJeanMehu, thanks!

Proposed solution

According to the metadata (i.e. ogImage) I would recommend using the lodash for the value check:

import _ from 'lodash';
...
      {!_.has(props, 'ogImage.value[0].url') ? null : (  // current state =>  {!props.ogImage ? null : (
        <meta property=\"og:image\" content={props.ogImage.value[0].url} />
      )}
@Simply007 Simply007 added enhancement help wanted refactoring up-for-grabs good first issue groomed The issue has been groomed and should be in a good shape. labels Feb 18, 2019
@Simply007 Simply007 changed the title Handle missing values in Preview fot Metadata component Handle missing values in Preview for Metadata component Feb 18, 2019
@Karl-EdwardFPJeanMehu
Copy link
Contributor

I'm interested.

@petrsvihlik
Copy link
Contributor

Hi @Karl-EdwardFPJeanMehu , I've just sent you an invitation to the project. I'll be able to assign the issue to you once you accept it.

Karl-EdwardFPJeanMehu added a commit to Karl-EdwardFPJeanMehu/cloud-sample-app-react that referenced this issue Feb 21, 2019
Karl-EdwardFPJeanMehu added a commit to Karl-EdwardFPJeanMehu/cloud-sample-app-react that referenced this issue Feb 28, 2019
@Simply007 Simply007 reopened this May 6, 2019
Simply007 added a commit that referenced this issue May 6, 2019
Handle missing values in metadata component. Closes #126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants