Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix latest article check for image data exists #24

Merged
merged 1 commit into from
Nov 23, 2018
Merged

Fix latest article check for image data exists #24

merged 1 commit into from
Nov 23, 2018

Conversation

Simply007
Copy link
Contributor

Motivation

Related to #19 - using an indexer in if condition.

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docu has been updated (if applicable)
  • Temporary settings (e.g. project ID used during development and testing) have been reverted to defaults

How to test

Run the app against the sample project and see that the latest article is displayed.

@Simply007 Simply007 mentioned this pull request Nov 23, 2018
Merged
5 tasks
@Simply007 Simply007 requested a review from makma November 23, 2018 08:45
@Simply007 Simply007 self-assigned this Nov 23, 2018
@Simply007 Simply007 merged commit ac56f69 into master Nov 23, 2018
@Simply007 Simply007 deleted the latestarticlefix branch November 23, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makma makma makma approved these changes

Assignees

@Simply007 Simply007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simply007 @makma