Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Run from /addon so we can run as non-root user #703

Merged
merged 1 commit into from
Oct 10, 2024
Merged

✨ Run from /addon so we can run as non-root user #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions external-providers/java-external-provider/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ FROM quay.io/konveyor/jdtls-server-base
COPY --from=builder /java-provider/java-external-provider /usr/local/bin/java-external-provider

EXPOSE 14651

ENTRYPOINT ["java-external-provider", "--port", "14651"]
WORKDIR /addon
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would /tmp be a better (more agnostic) default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawn-hurley @pranavgaikwad @fabianvf any opinions? /tmp sound good to me, but you all know far more about this project than I do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that /addon is good IMO

ENTRYPOINT ["java-external-provider", "--port", "14651"]
Loading