Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove references to tackle2-operator from Readme #255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

punithnayak
Copy link

@savitharaghunathan can you please check if it is correct

Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @punithnayak,
The changes in this PR are throwing 404 error. For now, lets hold on this PR. I will add more details to the original issue soon on what to actually change.

@savitharaghunathan
Copy link
Member

/hold

@jmontleon
Copy link
Member

This requires signoff for DCO and there are merge conflicts. Can this be cleaned up and we can go ahead and merge it?

@@ -50,15 +50,15 @@ Released (or public betas) of Konveyor are installable on Kubernetes via [Operat

Deploy Konveyor using manifest:

`$ kubectl apply -f https://raw.githubusercontent.com/konveyor/tackle2-operator/main/tackle-k8s.yaml`
`$ kubectl apply -f https://raw.githubusercontent.com/konveyor/konveyor-operator/main/tackle-k8s.yaml`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`$ kubectl apply -f https://raw.githubusercontent.com/konveyor/konveyor-operator/main/tackle-k8s.yaml`
`$ kubectl apply -f https://raw.githubusercontent.com/konveyor/operator/main/tackle-k8s.yaml`


This step will create the konveyor-tackle namespace, catalogsource and other OLM related objects.

### Installing _beta_ (or special branches)

If you need to deploy a beta release (or special branch) please replace the *main* branch in URL with the desired beta branch (i.e v2.0.0-beta.0):

`$ kubectl apply -f https://raw.githubusercontent.com/konveyor/tackle2-operator/v2.0.0-beta.0/tackle-k8s.yaml`
`$ kubectl apply -f https://raw.githubusercontent.com/konveyor/konveyor-operator/v2.0.0-beta.0/tackle-k8s.yaml`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`$ kubectl apply -f https://raw.githubusercontent.com/konveyor/konveyor-operator/v2.0.0-beta.0/tackle-k8s.yaml`
`$ kubectl apply -f https://raw.githubusercontent.com/konveyor/operator/v2.0.0-beta.0/tackle-k8s.yaml`

@@ -112,7 +112,7 @@ Released (or public betas) of Konveyor are installable on OpenShift via communit

Installing latest is almost an identical procedure to released versions but requires creating a new catalog source.

1. `oc apply -f https://raw.githubusercontent.com/konveyor/tackle2-operator/main/konveyor-operator-catalog.yaml`
1. `oc apply -f https://raw.githubusercontent.com/konveyor/konveyor-operator/main/konveyor-operator-catalog.yaml`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. `oc apply -f https://raw.githubusercontent.com/konveyor/konveyor-operator/main/konveyor-operator-catalog.yaml`
1. `oc apply -f https://raw.githubusercontent.com/konveyor/operator/main/konveyor-operator-catalog.yaml`

@djzager djzager changed the title Remove references to tackle2-operator from Readme 🌱 Remove references to tackle2-operator from Readme Jan 22, 2024
@jmontleon jmontleon added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-dco labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-dco needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants