Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Change Preemption column tooltip to indicate that tasks are re-scheduled #2059

Merged
merged 2 commits into from
Aug 30, 2024
Merged

🐛 Change Preemption column tooltip to indicate that tasks are re-scheduled #2059

merged 2 commits into from
Aug 30, 2024

Conversation

rszwajko
Copy link
Collaborator

Resolves: #2053

@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.53%. Comparing base (b654645) to head (f2a1099).
Report is 220 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2059      +/-   ##
==========================================
+ Coverage   39.20%   42.53%   +3.33%     
==========================================
  Files         146      171      +25     
  Lines        4857     5504     +647     
  Branches     1164     1305     +141     
==========================================
+ Hits         1904     2341     +437     
- Misses       2939     3147     +208     
- Partials       14       16       +2
Flag Coverage Δ
client 42.53% <ø> (+3.33%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rszwajko
Copy link
Collaborator Author

rszwajko commented Aug 22, 2024 •
edited
Loading

image

@rszwajko rszwajko requested a review from jortel August 22, 2024 15:53
@rszwajko rszwajko marked this pull request as ready for review August 22, 2024 15:53
sjd78
sjd78 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jortel - Does this version of the tooltip text look correct to you?

@rszwajko
Change Preemption column tooltip to indicate that other tasks are re-…
54a6484 
…scheduled

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@sjd78 sjd78 added this to the v0.5.2 milestone Aug 30, 2024
@sjd78 sjd78 added the cherry-pick/release-0.5 This PR should be cherry-picked to release-0.5 branch. label Aug 30, 2024
@sjd78 sjd78 merged commit 236cf63 into konveyor:main Aug 30, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 30, 2024
@rszwajko @web-flow
🐛 Change Preemption column tooltip to indicate that tasks are re-sche…
1623eb7 
…duled (#2059)

Resolves: #2053

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
sjd78 pushed a commit that referenced this pull request Aug 30, 2024
@konveyor-ci-bot
🐛 Change Preemption column tooltip to indicate that tasks are re-sche…
36987ae 
…duled (#2059) (#2072)

Resolves: #2053

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
This was referenced Oct 1, 2024
Merged
Merged
This was referenced Jan 10, 2025
Merged
Merged
This was referenced Jan 23, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jortel jortel jortel left review comments

@sjd78 sjd78 sjd78 approved these changes

@ibolton336 ibolton336 Awaiting requested review from ibolton336 ibolton336 is a code owner

Assignees
No one assigned
Labels
cherry-pick/release-0.5 This PR should be cherry-picked to release-0.5 branch.
Projects
None yet
Milestone
v0.5.2
Development

Successfully merging this pull request may close these issues.

[BUG] Preemption column help needs re-wording.
3 participants
@rszwajko @jortel @sjd78