initial output plugin #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgwozdz
approved these changes
Aug 11, 2021
LICENSE
Outdated
| same "printed page" as the copyright notice for easier | ||
| identification within third-party archives. | ||
|
|
||
| Copyright {yyyy} {name of copyright owner} |
There was a problem hiding this comment.
I think you need to add year and Owner.
| 'Create your own initiative by combining existing applications with a custom site. Use this initiative to form teams around a problem and invite your community to participate.', | ||
| tags: ['Hub Site'], | ||
| snippet: | ||
| 'I love front end development and everyone I\'ve met as Esri so far has been really nice and pleasant and I am excited to get to know everyone better yes', |
There was a problem hiding this comment.
Lol—that's from Jules.
| beforeEach(() => { | ||
| jest.resetModules(); | ||
|
|
||
| // const { |
There was a problem hiding this comment.
Do we still need this commented out code?
There was a problem hiding this comment.
It's coming back in the next PR.
sonofflynn89
approved these changes
Aug 11, 2021
| import { FeedFormatterStream } from './feed-formatter-stream'; | ||
|
|
||
| export function getDataStreamDcatUs11(siteItem: IItem) { | ||
| console.log(siteItem); |
There was a problem hiding this comment.
Just a friendly reminder to remove this when you can 😁
There was a problem hiding this comment.
Thank you! Yeah, just my attempt to get around Typescript's checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tooling, output plugin class, a placeholder feed function, and tests.
This lays the groundwork for porting the actual DCAT-US logic from Indexer.