Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Datasets into DCAT Feed #2

Merged
merged 11 commits into from
Aug 12, 2021
Merged

Format Datasets into DCAT Feed #2

merged 11 commits into from
Aug 12, 2021

Conversation

drewdaemon
Copy link
Contributor

This PR ports the hub-indexer code for formatting datasets to our Koop output plugin. Custom DCAT configurations are not supported but will be added in a separate PR.

src/dcat-us/base-template.ts Outdated Show resolved Hide resolved
src/dcat-us/dataset-formatter.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@sonofflynn89 sonofflynn89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just move the distro logic to another file and rename 'dataset' to 'hubDataset' and everything will be good! Thanks for doing this!

src/dcat-us/dataset-formatter.ts Outdated Show resolved Hide resolved
Copy link
Member

@rgwozdz rgwozdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

Lots of use of any as a type. Can we use more specific types?

src/dcat-us/dataset-formatter.ts Outdated Show resolved Hide resolved
src/dcat-us/dataset-formatter.ts Outdated Show resolved Hide resolved
src/dcat-us/dataset-formatter.ts Outdated Show resolved Hide resolved
src/dcat-us/dataset-formatter.ts Outdated Show resolved Hide resolved
src/dcat-us/dataset-formatter.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@sonofflynn89 sonofflynn89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the distributions logic! It looks great!

@drewdaemon drewdaemon merged commit 5a6b20f into main Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants