F/3978 customizable spatial attribute #25
Conversation
| @@ -944,7 +942,7 @@ describe('formatDcatDataset', () => { | |||
| } | |||
| }); | |||
|
|
|||
| it('overwrites critical fields without values to an empty string', () => { | |||
| it('does not define spatial property when template does not specify it', () => { | |||
There was a problem hiding this comment.
It looks like you may have deleted the generic overwrites critical fields test instead of just adding tests for spatial. If that's the case, would you mind adding it back in?
There was a problem hiding this comment.
It turns out that once you remove spatial there are no longer any, at least from what I can tell, non-editable fields that are at the dataset-level, instead they are all feed-level or will never get populated by the dataset (contactPoint[@type]). If this is incorrect i can add back in pretty easily
There was a problem hiding this comment.
Sorry for the false alarm, you're right. The git diff was a little tricky so I thought that more was in that test.
| fail('Should not throw!'); | ||
| } | ||
| const formatted = JSON.parse(formatDcatDataset(dataset, siteUrl, siteModel, buildDatasetTemplate({ spatial: undefined }))); | ||
| expect(formatted.hasOwnProperty('spatial')).toBeFalsy(); |
There was a problem hiding this comment.
The test title says does not define spatial property, so perhaps we should check with .toBeUndefined() instead of .toBeFalsy()to be more explicit.
There was a problem hiding this comment.
And if this is something you change, we'll want to change it in all the other tests too
There was a problem hiding this comment.
In this case I am actually being more specific.
The test should fail if spatial is ever returned with an undefined value. In that case, expect(format.spatial).toBeUndefined() does not actually assert what we want, as { spatial: undefined } would pass the test when it should fail. Instead, each dataset should not have the property at all, hence why I went with hasOwnProperty.
There was a problem hiding this comment.
🤦♂️ Sorry, the hasOwnProperty didn't register in my mind until you pointed it out. You are good to go.
This PR:
extentoritemExtentfields. The returned string is always 4 numbers fixed to 4 decimals each