Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change license field to reflect structuredLicense.url or default to empty string #3

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Change license field to reflect structuredLicense.url or default to empty string #3

merged 2 commits into from
Sep 7, 2021

Conversation

sonofflynn89
Copy link
Collaborator

drewdaemon
drewdaemon reviewed Sep 3, 2021
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request: we're trying to move toward marking properties as null when they're unavailable. Could we use null instead of the empty string?

@sonofflynn89
Copy link
Collaborator Author

I have no problem as long as Thomas is ok with it! He specifically asked for the empty string in the issue, but I'm sure he'll be fine with null.

@sonofflynn89
Copy link
Collaborator Author

@andrewctate Thomas approved and '' has been changed to null.

drewdaemon
drewdaemon approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@sonofflynn89 sonofflynn89 merged commit cdb0924 into main Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonofflynn89 @drewdaemon