F/1774 add sandbox capabilities #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonofflynn89
force-pushed
the
f/1774-add-sandbox-capabilities
branch
from
331b9c3
to
e2023d3
Compare
drewdaemon
approved these changes
Oct 1, 2021
src/index.ts
Outdated
Comment on lines
87
to
94
| private extractDatasetSearchRequest(req): IContentSearchRequest { | ||
| let searchRequest: IContentSearchRequest = null; | ||
| const id = _.get(req, 'query.id'); | ||
| if (id) { | ||
| searchRequest = this.getDatasetSearchRequest(id, portalUrl, []); | ||
| } | ||
| return searchRequest; | ||
| } |
There was a problem hiding this comment.
I think that passing an ID instead of the request object makes sense here and reduces coupling between this function and the express framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://devtopia.esri.com/dc/hub/issues/1774
Adds
dcatConfigandidquery params.?dcatConfig="{\"customProperty\":\"custom value\"}"?id= 1c36f0f21ba34a7aa1f5d48f7313cf6b_0dcatConfigis ignored if it is malformed JSON.if
idis invalid or refers to a private item, the feed will return empty.