diff/show/apply: Simplify JSON diffs/patches #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #71 we haven't used GeoJSON for diffs or patches, however we still have some GeoJSON artifacts that are now unnecessary and unused. This moves all feature attributes into the feature object, and removes the `properties`, `geometry` and `id` keys.
craigds
force-pushed
the
simplify-json-diffs
branch
from
eeba752
to
c63335f
Compare
olsen232
approved these changes
Jun 13, 2020
There was a problem hiding this comment.
Fine by me
@UberMouse is already using the json output of sno diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #71 we haven't used GeoJSON for diffs or patches,
however we still have some GeoJSON artifacts that are now unnecessary
and unused.
This moves all feature attributes into the feature object, and
removes the
properties,geometryandidkeys.