Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for datasets V1 (except for upgrade) #342

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Conversation

olsen232
Copy link
Collaborator

@olsen232 olsen232 commented Jan 12, 2021

Note that this PR comes in two commits -

  • the first part simply removes or upgrades all tests that rely on V1 datasets working properly:

    • for tests which come in pairs, with a V1 and a V2 variant, the V1 variant is simply removed
    • for a test which currently only tests against a V1 repo, it is modified to test against a V2 repo

    This part took a lot of small changes, but isn't very exciting.

  • the second part actually drops support for V1 - trying to run any command except for
    sno upgrade or sno data version on a V1 repo, will simply cause an error message to be displayed:

    Sno repo uses Datasets v1, which is no longer supported.
    The latest version is v2. Use `sno upgrade SOURCE DEST` to upgrade this repo.
    

    This part also has lots of small changes, and is also not very exciting, but probably more worth your time.

Checklist:!

  • Have you reviewed your own change?
  • Have you included test(s)?
  • Have you updated the changelog?

sno/repo.py Outdated Show resolved Hide resolved
tests/test_data.py Outdated Show resolved Hide resolved
tests/test_diff.py Outdated Show resolved Hide resolved
tests/test_diff.py Outdated Show resolved Hide resolved
Copy link
Member

@craigds craigds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice work

@olsen232 olsen232 merged commit 8fb7c1c into master Jan 13, 2021
@olsen232 olsen232 deleted the v1deprecation branch January 13, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants