CLI helper improvements #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* set C standard to C11 * create kart/kart_cli symlinks in dev, not just bundle * enable debug via `-DCMAKE_BUILD_TYPE=Debug`
Enable via -DCMAKE_BUILD_TYPE=Debug at build-time and setting KART_HELPER_DEBUG=1 in the environment.
Search for the kart executable via OS-specific methods if possible, falling back to argv[0]. Then look for sibling kart_cli. Then try again after re-resolving symlinks.
If Kart is built with -DCLI_HELPER=ON then make it on by default.
* enable test-run helper logging and dump log file after e2e tests * turn off/on explicitly to deal with helper mode being default enabled
* handle semget() flags correctly per-OS * add pid to log messages * make semnum a constant * build with -Wall & -Werror
* write to helper log from helper & children, resolve to absolute path so that cwd changes don't break * more detailed logging around forks/pids, and exit/semaphore messaging * `union semun` is defined differently on Linux & macOS... even though they're effectively the same, reflect accurately On macOS/arm64, it's critical to define the final argument to semctl() as variadic via ctypes (ie: don't define it), because the calling convention differs between fixed and variadic arguments. python/cpython#92892
we set it to ignore in the helper itself, but if the execution kart process invokes a subprocess (eg: git) and interacts via asyncio, then the subprocess exit code is lost on Linux. Reset it to the default after the fork happens.
Means local development builds don't have gotchas wrt code-reloading, but CI & release builds include it. Add a note to the contributing docs.
olsen232
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes and improvements for the CLI helper:
kart_clibinaryTo skip using the background helper, setting
KART_USE_HELPER=0in the environment continues to work.Related links:
Checklist: